[llvm] r253539 - [Support] Disable SaturatingMultiply() unit test while investigating

Nathan Slingerland via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 21:20:17 PST 2015


Author: slingn
Date: Wed Nov 18 23:20:17 2015
New Revision: 253539

URL: http://llvm.org/viewvc/llvm-project?rev=253539&view=rev
Log:
[Support] Disable SaturatingMultiply() unit test while investigating

Ubsan detected undefined behavior in the MathExtras SaturatingMultiply test.

This change disables the test while it is being investigated.

Modified:
    llvm/trunk/unittests/Support/MathExtrasTest.cpp

Modified: llvm/trunk/unittests/Support/MathExtrasTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/MathExtrasTest.cpp?rev=253539&r1=253538&r2=253539&view=diff
==============================================================================
--- llvm/trunk/unittests/Support/MathExtrasTest.cpp (original)
+++ llvm/trunk/unittests/Support/MathExtrasTest.cpp Wed Nov 18 23:20:17 2015
@@ -207,23 +207,4 @@ TEST(MathExtras, SaturatingAdd) {
   SaturatingAddTestHelper<uint64_t>();
 }
 
-template<typename T>
-void SaturatingMultiplyTestHelper()
-{
-  const T Max = std::numeric_limits<T>::max();
-  EXPECT_EQ(T(0), SaturatingMultiply(T(1), T(0)));
-  EXPECT_EQ(T(0), SaturatingMultiply(T(0), T(1)));
-  EXPECT_EQ(T(6), SaturatingMultiply(T(2), T(3)));
-  EXPECT_EQ(Max, SaturatingMultiply(Max, T(2)));
-  EXPECT_EQ(Max, SaturatingMultiply(T(2),Max));
-  EXPECT_EQ(Max, SaturatingMultiply(Max, Max));
-}
-
-TEST(MathExtras, SaturatingMultiply) {
-  SaturatingMultiplyTestHelper<uint8_t>();
-  SaturatingMultiplyTestHelper<uint16_t>();
-  SaturatingMultiplyTestHelper<uint32_t>();
-  SaturatingMultiplyTestHelper<uint64_t>();
-}
-
 }




More information about the llvm-commits mailing list