[PATCH] D14786: [llvm-profdata] Add merge() to InstrProfRecord

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: lib/ProfileData/InstrProfWriter.cpp:111
@@ -139,1 +110,3 @@
+      return MergeResult;
+    }
   }
----------------
davidxl wrote:
> else {
>    Dest = std::forward<InstrProfRecord>(I);
> }
> 
> the std::forward is missing in the old code too which is less efficient.
Sorry, should be 

Dest = std::move(I) or
Dest = static_cast<InstrProfRecord&&>(I)


http://reviews.llvm.org/D14786