[PATCH] D14789: libc++abi: mark visibility

Saleem Abdulrasool via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 18:40:57 PST 2015


compnerd added inline comments.

================
Comment at: include/__cxxabi_config.h:24
@@ +23,3 @@
+
+#if defined(LIBCXXABI_DLL)
+ #if defined(cxxabi_EXPORTS)
----------------
jroelofs wrote:
> s/LIBCXXABI_DLL/_LIBCXXABI_DLL/
Sure, though the thing is that this would be different from libc++, which uses `LIBCPP_DLL`.


http://reviews.llvm.org/D14789





More information about the llvm-commits mailing list