[PATCH] D14698: [tsan] Implement "%env_tsan_opts" substitution to inherit default TSAN_OPTIONS

[Alexey Samsonov via llvm-commits]

samsonov added inline comments.

================
Comment at: test/tsan/deadlock_detector_stress_test.cc:3
@@ -4,1 +2,3 @@
+// RUN: %env_tsan_opts=detect_deadlocks=1 %deflake %run %t | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-NOT-SECOND
+// RUN: %env_tsan_opts="detect_deadlocks=1 second_deadlock_stack=1" %deflake %run %t | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-SECOND
 // RUN: %clangxx_tsan %s -o %t -DLockType=PthreadSpinLock
----------------
dvyukov wrote:
> samsonov wrote:
> > remove quotes and use `:` as a delimiter here.
> why?
> space-delimited options is supported format that must continue to work
The problem is not space-delimited options, after applying substitution the string would look like:

  env TSAN_OPTIONS=atexit_sleep_ms=0:"detect_deadlocks=1 second_deadlock_stack=1"

which is probably not what is desired



http://reviews.llvm.org/D14698