[PATCH] D14714: [compiler-rt] Add internal implementations for strlcat and strlcpy

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 15:18:32 PST 2015


kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.

LGTM with one nit


================
Comment at: lib/sanitizer_common/tests/sanitizer_libc_test.cc:149
@@ -147,1 +148,3 @@
 
+#define STRLCPY_BUF_SIZE 8
+void test_internal_strlcpy(char *dbuf, const char *sbuf) {
----------------
use 
  static const size_t kStrlcpyBufSize = 8; 


http://reviews.llvm.org/D14714





More information about the llvm-commits mailing list