[PATCH] D14778: [PPC64] Enable shrink wrapping for PPC64 LE.
Quentin Colombet via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 18 14:56:56 PST 2015
qcolombet added inline comments.
================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:581
@@ +580,3 @@
+ MachineBasicBlock::iterator MBBI = MBB->getFirstTerminator();
+ // If no terminator, back iterator up to previous instruction
+ if (MBBI == MBB->end())
----------------
Period.
================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:585
@@ +584,3 @@
+
+ if (MBBI != MBB->begin())
+ RS.forward(MBBI);
----------------
You still need to check that “begin” is not the terminator, otherwise, you’ll get the available register after the terminator, not before.
http://reviews.llvm.org/D14778
More information about the llvm-commits
mailing list