[PATCH] D14757: Handle ARMv7K as an alias, instead of fake architecture (NFC)

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 14:34:44 PST 2015


t.p.northover added a comment.

I'm not really sure about this. To the extent that the arch part of the triple means anything on MachO targets, it's a CPU choice (possibly with accompanying ABI upgrades, like x86_64h).

Defaulting watchOS to Cortex-A7 achieves the right thing on existing triples, but for what seem like dodgy reasons to me.


================
Comment at: lib/Support/Triple.cpp:1378
@@ +1377,3 @@
+    // fall through
+  case llvm::Triple::TvOS:
+  case llvm::Triple::WatchOS:
----------------
tvOS probably ought to default to "cyclone" if anything.


http://reviews.llvm.org/D14757





More information about the llvm-commits mailing list