[PATCH] D9887: [DebugInfo][FastISel] Prevent using debug location from previous block for local values

[Eric Christopher via llvm-commits]

echristo added a subscriber: probinson.
echristo added a comment.

Hi, I apologize for the delay on this.

So, this is a hack on top of a hack on top of an optimization :)

Basically the "right" thing we should do is emit location information on constant loads. However, that was removed a while back IIRC by (or because of) Paul as stepping through code would jump around quite a bit because of the optimization where we only want to load a particular constant once and so we load it at the top of the block with the last location used.

I think the best thing for this would be either to remove the hack where we don't put locations on constant loads (which will lead us back to jumping around in blocks) or we can come up with a better optimization to handle "we actually want the constant load as close to the use as possible without multiple constant loads".

Thoughts?

-eric


Repository:
  rL LLVM

http://reviews.llvm.org/D9887