[PATCH] D14782: test/DebugInfo/Generic/missing-abstract-variable.ll fails on arm

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 13:50:25 PST 2015


rengolin requested changes to this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision now requires changes to proceed.

Hi Weiming,

The buildbots are green for a good number of years, so they're pretty good baseline for you to see if the problem happens upstream or not, meaning XFAILing tests on ARM or AArch64 are no longer accepted as a solution.

It may be that whatever revision you have in your tree broke that test, or that your environment is slightly different, but the bots are authoritative (we have to have some baseline). They have a list of commits you can look at to make sure your tree is as up-to-date as the bots, and if not, you should either update it or look down the waterfall to see if the particular commit you have fails or not.

Regardless, if the bots are currently green, XFAILing a test will break them. If it's not, fixing the problem is the best solution.

cheers,
--renato


http://reviews.llvm.org/D14782





More information about the llvm-commits mailing list