[llvm] r253494 - [OperandBundles] Address review on r253446; NFC

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 11:44:59 PST 2015


Author: sanjoy
Date: Wed Nov 18 13:44:59 2015
New Revision: 253494

URL: http://llvm.org/viewvc/llvm-project?rev=253494&view=rev
Log:
[OperandBundles] Address review on r253446; NFC

Post-commit review by David Blaikie, thanks David!

Modified:
    llvm/trunk/include/llvm/IR/InstrTypes.h

Modified: llvm/trunk/include/llvm/IR/InstrTypes.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/InstrTypes.h?rev=253494&r1=253493&r2=253494&view=diff
==============================================================================
--- llvm/trunk/include/llvm/IR/InstrTypes.h (original)
+++ llvm/trunk/include/llvm/IR/InstrTypes.h Wed Nov 18 13:44:59 2015
@@ -1160,18 +1160,18 @@ template <typename InputTy> class Operan
   std::vector<InputTy> Inputs;
 
 public:
-  explicit OperandBundleDefT(StringRef Tag, std::vector<InputTy> &&Inputs)
-      : Tag(Tag), Inputs(Inputs) {}
+  explicit OperandBundleDefT(StringRef Tag, std::vector<InputTy> Inputs)
+      : Tag(Tag), Inputs(std::move(Inputs)) {}
 
-  explicit OperandBundleDefT(std::string &&Tag, std::vector<InputTy> &&Inputs)
-      : Tag(Tag), Inputs(Inputs) {}
+  explicit OperandBundleDefT(std::string Tag, std::vector<InputTy> Inputs)
+      : Tag(std::move(Tag)), Inputs(std::move(Inputs)) {}
 
   explicit OperandBundleDefT(const OperandBundleUse &OBU) {
     Tag = OBU.getTagName();
     Inputs.insert(Inputs.end(), OBU.Inputs.begin(), OBU.Inputs.end());
   }
 
-  ArrayRef<InputTy> getInputs() const { return Inputs; }
+  ArrayRef<InputTy> inputs() const { return Inputs; }
 
   typedef typename std::vector<InputTy>::const_iterator input_iterator;
   size_t input_size() const { return Inputs.size(); }




More information about the llvm-commits mailing list