[PATCH] D14774: [ARM] Add +feature names to TargetParser extensions table

[Renato Golin via llvm-commits]

rengolin added inline comments.

================
Comment at: include/llvm/Support/ARMTargetParser.def:113
@@ +112,3 @@
+ARM_ARCH_EXT_NAME("crc",      AEK_CRC,      "+crc",   "-crc")
+ARM_ARCH_EXT_NAME("crypto",   AEK_CRYPTO,   nullptr,  nullptr)
+ARM_ARCH_EXT_NAME("fp",       AEK_FP,       nullptr,  nullptr)
----------------
I thought crypto would have, too.

================
Comment at: lib/Support/TargetParser.cpp:335
@@ +334,3 @@
+const char *llvm::ARM::getArchExtFeature(StringRef ArchExt) {
+  for (const auto AE : ARCHExtNames) {
+    if (ArchExt == AE.getName())
----------------
Most extensions don't have a name, it'd be good to avoid constructing a StringRef out of a nullptr + another out of "no" + nullptr for every extension but one.


Repository:
  rL LLVM

http://reviews.llvm.org/D14774