[PATCH] D14755: Handle ARMv6-J as an alias, instead of fake architecture

[A. Skrobov via llvm-commits]

tyomitch added inline comments.

================
Comment at: unittests/ADT/TripleTest.cpp:855
@@ -854,3 +854,3 @@
     llvm::Triple Triple("armv6j-unknown-eabi");
-    EXPECT_EQ("arm1136j-s", Triple.getARMCPUForArch());
+    EXPECT_EQ("arm1136jf-s", Triple.getARMCPUForArch());
   }
----------------
rengolin wrote:
> Non-functional triples were recorded because of the default CPU they had more than what they actually meant. In this case, the difference is between having VFP or not, which makes a huge difference on soft vs hard float and could wreak havoc on build systems.
> 
> I'm not saying that it's a good idea to keep the unknown legacy, but we gotta at least give some thought to this change.
Wow, so the difference between armv6j and armv6 triples is not Jazelle but VFP?

Couldn't be any more obscure than this...


http://reviews.llvm.org/D14755