[llvm] r253426 - Remove a redundant assertion in MachineBasicBlock.cpp. NFC.

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 17 22:32:35 PST 2015


On 11/17/2015 05:55 PM, Cong Hou via llvm-commits wrote:
> Author: conghou
> Date: Tue Nov 17 19:55:56 2015
> New Revision: 253426
>
> URL: http://llvm.org/viewvc/llvm-project?rev=253426&view=rev
> Log:
> Remove a redundant assertion in MachineBasicBlock.cpp. NFC.
>
>
> Modified:
>      llvm/trunk/lib/CodeGen/MachineBasicBlock.cpp
>
> Modified: llvm/trunk/lib/CodeGen/MachineBasicBlock.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineBasicBlock.cpp?rev=253426&r1=253425&r2=253426&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/MachineBasicBlock.cpp (original)
> +++ llvm/trunk/lib/CodeGen/MachineBasicBlock.cpp Tue Nov 17 19:55:56 2015
> @@ -545,7 +545,6 @@ void MachineBasicBlock::addSuccessorWith
>   
>   void MachineBasicBlock::removeSuccessor(MachineBasicBlock *Succ) {
>     succ_iterator I = std::find(Successors.begin(), Successors.end(), Succ);
> -  assert(I != Successors.end() && "Not a current successor!");
Why is this redundant?  It appears to be checking whether Succ is 
actually a successor of this.  That seems useful to say the least?
>     removeSuccessor(I);
>   }
>   
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list