[llvm] r253170 - Fix mapping of unmaterialized global values during metadata linking

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 17 15:43:52 PST 2015


On Tue, Nov 17, 2015 at 3:37 PM, Peter Collingbourne <peter at pcc.me.uk> wrote:
> On Sun, Nov 15, 2015 at 02:50:14PM -0000, Teresa Johnson via llvm-commits wrote:
>> Author: tejohnson
>> Date: Sun Nov 15 08:50:14 2015
>> New Revision: 253170
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=253170&view=rev
>> Log:
>> Fix mapping of unmaterialized global values during metadata linking
>
> Hi Teresa,
>
> Would it be too much trouble to come up with a test case? What I had in
> mind was that you could put the code change in my patch [1] behind a flag
> and use that flag in your test.

Yea, I was wondering how to add a test case without making the
llvm-link change. That sounds reasonable to put it behind a flag. Will
work adding that.

Thanks,
Teresa

>
> Thanks,
> --
> Peter
>
> [1] http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20151109/312869.html



-- 
Teresa Johnson | Software Engineer | tejohnson at google.com | 408-460-2413


More information about the llvm-commits mailing list