[PATCH] D14690: Don't force std::set for SmallSet

[Duncan P. N. Exon Smith via llvm-commits]

> On 2015-Nov-16, at 18:34, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> 
> Yes, there is a lot of stuff to fix. I was hopping this was a low
> hanging fruit, but as you point out having a DenseSet in the SmallSet
> defeats its purpose.
> 
> Unfortunately I don't have time now to fix the bigger problem :-(

Some day someone will fix it...

> The attached patch is the other option for a low hanging fruit. It
> changes just SetVector. Since there is a SmallSetVector, is it OK?

LGTM.  Maybe be clear in the commit message that explicitly asking
for a `SmallSet` will revert to the old behaviour, so if this
explodes in out-of-tree code it's super obvious how to fix it.

Come to think of it, it'd probably be best to post an FYI on
llvm-dev after/before you commit.

> Cheers,
> Rafael
> <t.diff>