[PATCH] D14743: [ARM] Don't pessimize i32 vselect.

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 17 01:27:55 PST 2015


rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.

Hi Charlie,

The original commit mentions Cortex-A8's 25% improvement performance in PAQp8. It seems you've only tested in OOO cores, can you just double check on either A53 or A7/A8? It's probably a pattern we now recognise better, but would be good to be on the safe side.

If you find no regressions either, and I'm not expecting any, LGTM. Thanks!

cheers,
--renato


Repository:
  rL LLVM

http://reviews.llvm.org/D14743





More information about the llvm-commits mailing list