[PATCH] D14720: [llvm-profdata] Add SaturatingAdd/SaturatingMultiply Helper Functions

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 16 19:45:30 PST 2015


The way InstrProf handles overflow is a little extreme (by skipping the
record for the whole function). I think Using saturating add with some form
of warning is better.

David

On Mon, Nov 16, 2015 at 3:37 PM, Nathan Slingerland <slingn at gmail.com>
wrote:

> slingn added a comment.
>
> Related question:
>
> Is it by design that intstr profile count overflow is treated differently
> from sample profile count overflow?
> Instr profile merging appears to skip records that would result in
> overflow and print a warning. Sample profile count overflow saturates and
> does not show a warning.
>
>
> http://reviews.llvm.org/D14720
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151116/da0cb7b3/attachment.html>


More information about the llvm-commits mailing list