[PATCH] D14668: [WinEH] Move WinEHFuncInfo from MachineModuleInfo to MachineFunction

[Reid Kleckner via llvm-commits]

rnk added a comment.

In http://reviews.llvm.org/D14668#289319, @JosephTremoulet wrote:

> LGTM, nice cleanup.  Is there somewhere that "don't creates or removes EH pads between state pass and SDAG construction" should be documented as a comment?


I'll put something in X86WinEHStatePass. If this ends up being a problem, there's a clear path towards fixing it, but it requires a lot of extra work that will need to be redone with the new pass manager. We'd probably create a new ImmutablePass like MachineModuleInfo.

> Looking at this and thinking about the CLR's use of funclets on non-Windows platforms makes me want to rename all these WinEH constructs to FuncletEH, like we did with isFuncletEHPersonality, but really that's orthogonal to this change.


I agree. WinEHFuncInfo is not a good name for our bag of EH data structures. EHFuncletInfo? EHFuncletStates? EHFuncletTables?


http://reviews.llvm.org/D14668