[PATCH] D13631: [JIT/llvm-rtdyld] Don't waste cycles invalidating the Instruction cache
Lang Hames via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 16 09:18:38 PST 2015
lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.
LGTM, pending the removal of the icache invalidation for the data sections.
================
Comment at: tools/llvm-rtdyld/llvm-rtdyld.cpp:432
@@ -447,1 +431,3 @@
+ for (auto &DM : MemMgr.DataMemory)
+ sys::Memory::InvalidateInstructionCache(DM.base(), DM.size());
----------------
The instruction cache doesn't need to be invalidated for data sections, so this loop should be removed.
http://reviews.llvm.org/D13631
More information about the llvm-commits
mailing list