[PATCH] D14709: Use TargetRegisterInfo for printing MachineOperand register comments

Dan Gohman via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 16 08:55:16 PST 2015


sunfish created this revision.
sunfish added a reviewer: echristo.
sunfish added a subscriber: llvm-commits.
sunfish set the repository for this revision to rL LLVM.
Herald added a reviewer: tstellarAMD.
Herald added subscribers: dsanders, dschuff, jfb.

Several places in AsmPrinter.cpp print comments describing MachineOperand registers using MCRegisterInfo, which uses MCOperand-oriented names. This doesn't work for targets that use virtual registers exclusively, as WebAssembly does, since virtual registers are represented and printed differently.

This patch preserves what seems to be the spirit of r229978, avoiding the use of TM.getSubtargetImpl(), while still using MachineOperand-oriented printing for MachineOperands.

Repository:
  rL LLVM

http://reviews.llvm.org/D14709

Files:
  lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  test/CodeGen/AMDGPU/llvm.dbg.value.ll
  test/CodeGen/ARM/debug-info-arg.ll
  test/CodeGen/ARM/debug-info-blocks.ll
  test/CodeGen/ARM/debug-info-branch-folding.ll
  test/CodeGen/BPF/sockex2.ll
  test/CodeGen/Mips/llvm-ir/call.ll
  test/CodeGen/X86/2010-05-28-Crash.ll
  test/CodeGen/X86/2010-06-01-DeadArg-DbgInfo.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14709.40295.patch
Type: text/x-patch
Size: 6621 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151116/67733ab6/attachment.bin>


More information about the llvm-commits mailing list