[PATCH] D14706: [lit] Implement support of per test timeout in lit.

[Jonathan Roelofs via llvm-commits]

jroelofs added inline comments.

================
Comment at: utils/lit/lit/main.py:208
@@ -207,1 +207,3 @@
                             " specified file"), default=None)
+    group.add_option("", "--max-individual-test-time", dest="maxIndividualTestTime",
+                     help="Maximum time to spend running a single test (in seconds)."
----------------
Please name the flag "--timeout" so it's easier to type out on the `llvm-lit` command line.  It's probably a good idea to keep the descriptive variable name though.

================
Comment at: utils/lit/tests/Inputs/per_test_timeout/slow.py:8
@@ +7,2 @@
+print("slow program")
+time.sleep(6)
----------------
The infinite loop testcase was actually useful to guarantee that the timeout detection & handling code isn't broken. With this testcase, it could be broken and we wouldn't notice (apart from the tests running a little slower).


http://reviews.llvm.org/D14706