[PATCH] D14687: Macro support in LLVM IR

[Duncan P. N. Exon Smith via llvm-commits]

This seems to be missing any changes to LangRef.

Do we really need to add a new field to DICompileUnit?  Why would the compile unit need to reference all the macros?

I don't understand why you need `MacroNode` separate from `DIMacro`.  `DIMacro` seems to be the only subclass, so why split it?  Also, is `MacroNode` meant for something other than debug info?  If it's for debug info, it should have a `DI`-prefix.  It should also inherit from `DINode`.

> On 2015-Nov-15, at 05:39, Amjad Aboud via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> aaboud created this revision.
> aaboud added reviewers: dblaikie, samsonov, echristo.
> aaboud added a subscriber: llvm-commits.
> aaboud set the repository for this revision to rL LLVM.
> 
> This patch introduce DIMacro and DIMacroFile debug info metadata in the LLVM IR to support macros.
> 
> Note: DIBuilder API for creating macro entries and emitting macro in dwarf sections will be committed in separate patches.
> 
> 
> Repository:
>  rL LLVM
> 
> http://reviews.llvm.org/D14687
> 
> Files:
>  include/llvm/Bitcode/LLVMBitCodes.h
>  include/llvm/IR/DebugInfoMetadata.h
>  include/llvm/IR/Metadata.def
>  include/llvm/IR/Metadata.h
>  include/llvm/Support/Dwarf.h
>  lib/AsmParser/LLLexer.cpp
>  lib/AsmParser/LLParser.cpp
>  lib/AsmParser/LLToken.h
>  lib/Bitcode/Reader/BitcodeReader.cpp
>  lib/Bitcode/Writer/BitcodeWriter.cpp
>  lib/IR/AsmWriter.cpp
>  lib/IR/DIBuilder.cpp
>  lib/IR/DebugInfoMetadata.cpp
>  lib/IR/LLVMContextImpl.h
>  lib/IR/Verifier.cpp
>  lib/Support/Dwarf.cpp
>  test/Assembler/debug-info.ll
>  test/Assembler/dicompileunit.ll
>  unittests/IR/MetadataTest.cpp
> 
> <D14687.40233.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits