[PATCH] D9009: Value profiling compiler-rt changes

[Xinliang David Li via llvm-commits]

Let me reexamine the code a little more to make sure reading cross platform
profiling reading (32 --> 64, 64->64) will be ok (I suppose there are test
coverage on that).

David

On Sun, Nov 15, 2015 at 1:11 PM, Betul Buyukkurt <betulb at codeaurora.org>
wrote:

>
> Hi David,
>
> Alignment is set to be 8 bytes for the ProfileData struct elements in
> lib/Transforms/Instrumentation/InstrProfiling.cpp through the line:
>
>  Data->setAlignment(8);
>
> I also checked the size of the ProfileData struct during raw test file
> updates. It came up to be 40 bytes i.e. assigning 6 bytes of padding to
> the 34 byte actual ProfileData struct size on a 32 byte architectures.
>
> I just got my commit rights. I'll merge the patches once I have an LGTM on
> them.
>
> -Betul
>
> > This may not be true for 32 bit target.
> >
> > David
> >
> > On Sun, Nov 15, 2015 at 6:23 AM, Betul Buyukkurt <betulb at codeaurora.org
> > <mailto:betulb at codeaurora.org> > wrote:
> >
> >
> > betulb updated this revision to Diff 40236.
> > betulb added a comment.
> >
> > In this revision:
> >
> > - Removed padding computation after the Data section. It's not needed as
> > the
> > ProfileData struct is 8 byte aligned.
> >
> >
> >
> > http://reviews.llvm.org/D9009
> >
> > Files:
> >   lib/profile/InstrProfiling.c
> >   lib/profile/InstrProfiling.h
> >   lib/profile/InstrProfilingBuffer.c
> >   lib/profile/InstrProfilingFile.c
> >
> >
> >
> >
> >
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151115/e112944c/attachment.html>