[PATCH] D14682: Fix mapping of unmaterialized global values during metadata linking

[Mehdi AMINI via llvm-commits]

joker.eph accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: include/llvm/Transforms/Utils/ValueMapper.h:73
@@ +72,3 @@
+
+    /// RF_NullMapMissingGlobalValues - Any global values not in value map are
+    /// mapped to null instead of mapping to self. Illegal if
----------------
No need to repeat `RF_NullMapMissingGlobalValues` in the doxygen.

================
Comment at: lib/Transforms/Utils/ValueMapper.cpp:47
@@ +46,3 @@
+    if (Flags & RF_NullMapMissingGlobalValues) {
+      assert(!(Flags & RF_IgnoreMissingEntries));
+      return nullptr;
----------------
A string with the assert is usually more user friendly.


http://reviews.llvm.org/D14682