[PATCH] D14571: [ELF2] - Implemented PT_GNU_STACK support, -z execstack option.
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Sat Nov 14 11:59:31 PST 2015
grimar added inline comments.
================
Comment at: test/elf2/gnustack.s:16
@@ +15,3 @@
+# CHECK_RW: PhysicalAddress: 0x10040
+# CHECK_RW: FileSize: 224
+# CHECK_RW: MemSize: 224
----------------
rafael wrote:
> This is checking way more than it needs. Check just the contents of PT_GNU_STACK and that we eat the section.
Ok. My way also checked that PT_GNU_STACK header is the last one but thats really probably not needed.
http://reviews.llvm.org/D14571
More information about the llvm-commits
mailing list