[PATCH] D14571: [ELF2] - Implemented PT_GNU_STACK support, -z execstack option.

[Rui Ueyama via llvm-commits]

Yes.
2015/11/14 6:59 "George Rimar" <grimar at accesssoftek.com>:

> grimar added inline comments.
>
> ================
> Comment at: ELF/Writer.cpp:545-546
> @@ -538,2 +544,4 @@
>          continue;
> +      if (!shouldOutputSection(C))
> +        continue;
>        const Elf_Shdr *H = C->getSectionHdr();
> ----------------
> ruiu wrote:
> > We don't use input files' .note.GNU-stack sections at all. Maybe we
> should ignore them in .note.GNU-stack?
> Do you mean ignore them in initializeSections ? Something like next ?
>
>
> ```
> switch (Sec.sh_type) {
> ...
>  default:
>     if (NameOrErr == ".note.GNU-stack")
>       Sections[I] = &InputSection<ELFT>::Discarded;
> ```
>
>
> http://reviews.llvm.org/D14571
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151114/30d7474f/attachment.html>