[PATCH] D14621: [ELF2] - Implemented R_X86_64_GOTTPOFF relocation

[George Rimar via llvm-commits]

grimar added a comment.

In http://reviews.llvm.org/D14621#288857, @rafael wrote:

> LGTM with a nit.
>  Maybe just pass body to getGotReloc?


Problem here is that currently there are two places in code that looks very similiar:

  1) Type = Body.isTLS() ? Target->getTlsGotReloc() : Target->getGotRefReloc();
  ...
  2) unsigned GotReloc =
    Body->isTLS() ? Target->getTlsGotReloc() : Target->getGotReloc();

But getGotRefReloc() and getGotReloc() are different calls. And it seems I cant just use the body argument to know which one relocation return for them in that places.


Repository:
  rL LLVM

http://reviews.llvm.org/D14621