[PATCH] D14280: [mips][microMIPS] Implement MUL[_S].PH, MULEQ_S.W.PHL, MULEQ_S.W.PHR, MULEU_S.PH.QBL, MULEU_S.PH.QBR, MULQ_RS.PH, MULQ_RS.W, MULQ_S.PH and MULQ_S.W instructions

[Daniel Sanders via llvm-commits]

dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with a small test change


================
Comment at: lib/Target/Mips/MicroMipsDSPInstrInfo.td:69
@@ -58,3 +68,3 @@
 
-// Instruction desc.
+//Instruction descriptions
 class ABSQ_S_PH_MM_R2_DESC_BASE<string opstr, SDPatternOperator OpNode,
----------------
Formatting nit: Bring back the space after '//' and the '.'

================
Comment at: test/MC/Disassembler/Mips/micromips-dspr2/valid.txt:18-22
@@ -17,1 +17,6 @@
 0x00 0x64 0xb1 0xfc # CHECK: shra_r.qb $3, $4, 5
+0x00 0x62 0x08 0x2d # CHECK: mul.ph $1, $2, $3
+0x00 0x62 0x0c 0x2d # CHECK: mul_s.ph $1, $2, $3
+0x00 0x62 0x09 0x95 # CHECK: mulq_rs.w $1, $2, $3
+0x00 0x62 0x09 0x55 # CHECK: mulq_s.ph $1, $2, $3
+0x00 0x62 0x09 0xd5 # CHECK: mulq_s.w $1, $2, $3
----------------
The DSPr1 tests should also be present. Likewise for the assembler tests.

See my comment on D14058 for more info.


http://reviews.llvm.org/D14280