[PATCH] D14174: [mips][microMIPS] Implement EXTP, EXTPDP, EXTPDPV, EXTPV, EXTR[_RS].W, EXTR_S.H, EXTRV[_RS].W and EXTRV_S.H instructions

[Daniel Sanders via llvm-commits]

dsanders added a comment.

Sorry, I missed a small detail.


================
Comment at: test/MC/Disassembler/Mips/micromips-dsp/valid.txt:31-42
@@ -30,1 +30,13 @@
 0x00 0x64 0x2b 0xf5 # CHECK: shll_s.w $3, $4, 5
+0x00 0x06 0x66 0x7c # CHECK: extp $zero, $ac1, 6
+0x00 0x42 0x76 0x7c # CHECK: extpdp $2, $ac1, 2
+0x00 0x88 0xb8 0xbc # CHECK: extpdpv $4, $ac2, $8
+0x01 0xe7 0xe8 0xbc # CHECK: extpv $15, $ac3, $7
+0x03 0x7f 0xce 0x7c # CHECK: extr.w $27, $ac3, 31
+0x01 0x98 0x1e 0x7c # CHECK: extr_r.w $12, $ac0, 24
+0x03 0x69 0xee 0x7c # CHECK: extr_rs.w $27, $ac3, 9
+0x00,0x61,0xbe,0x7c # CHECK: extr_s.h $3, $ac2, 1
+0x00,0xa6,0x0e,0xbc # CHECK: extrv.w $5, $ac0, $6
+0x01,0x43,0x1e,0xbc # CHECK: extrv_r.w $10, $ac0, $3
+0x01,0xf4,0x6e,0xbc # CHECK: extrv_rs.w $15, $ac1, $20
+0x01,0x10,0xbe,0xbc # CHECK: extrv_s.h $8, $ac2, $16
----------------
These should be copied to the DSPr2 tests too. Likewise for the assembler tests.

See my comment on D14058 for more info.


http://reviews.llvm.org/D14174