[PATCH] D14526: Don't recompute LCSSA after loop-unrolling when possible.

Michael Zolotukhin via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 17:28:11 PST 2015


mzolotukhin added inline comments.

================
Comment at: lib/Transforms/Utils/LoopUnroll.cpp:227
@@ +226,3 @@
+  Loop *ParentL = L->getParentLoop();
+  bool AllExitsAreInsideParentLoop = !ParentL ||
+      std::all_of(ExitBlocks.begin(), ExitBlocks.end(),
----------------
joker.eph wrote:
> It seems you didn't update the test, if it was passing before it means this is not tested in the non-regression suite?
I didn't wait for test-suite when I made this change as I erroneously considered it NFC. However, with it even compiler-rt failed to build, so we definitely have tests for this case.


http://reviews.llvm.org/D14526





More information about the llvm-commits mailing list