[PATCH] D14660: [ARM] Introduce subtarget features per ARM architecture

[Eric Christopher via llvm-commits]

echristo accepted this revision.
echristo added a comment.

I think this is ok. I've got one inline comment (to update a comment).

-eric


================
Comment at: include/llvm/MC/MCSubtargetInfo.h:90
@@ -89,3 +89,3 @@
   /// Set the features to the default for the given CPU.
-  void setDefaultFeatures(StringRef CPU);
+  void setDefaultFeatures(StringRef CPU, StringRef FS);
 
----------------
rengolin wrote:
> nitpick: FS may not be the best of names...
FS is what we use approximately everywhere else.

That said, the comment needs to be updated.


Repository:
  rL LLVM

http://reviews.llvm.org/D14660