[llvm] r243308 - [AArch64] Remove check for Darwin that was needed to decide if x18 should
Eric Christopher via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 13 14:41:13 PST 2015
On Fri, Nov 13, 2015 at 2:26 PM Tim Northover <tnorthover at apple.com> wrote:
> > I think the right thing to do is to default ReserveX18 in the
> > AArch64Subtarget constructor based on isOSDarwin. i.e.:
>
> I think I agree. The triple ought to be enough to give reasonably
> ABI-compliant code, otherwise why include the OS there in the first place?
>
Seems reasonable.
>
> > If we do this we can also revert r243310 since it'll become redundant.
> WDYT?
>
> Probably a good idea too.
>
Sure.
I think this will mean that it's not currently possible to turn it off, but
if we need that we can add a -mno- reserve option to clang.
-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151113/0c358770/attachment.html>
More information about the llvm-commits
mailing list