[PATCH] D14660: [ARM] Introduce subtarget features per ARM architecture

[Renato Golin via llvm-commits]

rengolin added a comment.

Hi Bradley,

Thanks for working on this, it's a massive improvement on the current state of sub-target description for ARM. I'd still like to hear Tim's and Eric's opinions, but the patch looks good to me.

cheers,
--renato


================
Comment at: include/llvm/MC/MCSubtargetInfo.h:90
@@ -89,3 +89,3 @@
   /// Set the features to the default for the given CPU.
-  void setDefaultFeatures(StringRef CPU);
+  void setDefaultFeatures(StringRef CPU, StringRef FS);
 
----------------
nitpick: FS may not be the best of names...

================
Comment at: lib/Target/ARM/ARM.td:183
@@ +182,3 @@
+//===----------------------------------------------------------------------===//
+// ARM ISAa.
+//
----------------
typo

================
Comment at: lib/Target/ARM/ARM.td:513
@@ +512,3 @@
+//        division features.
+def : ProcessorModel<"krait",       CortexA9Model,      [ARMv7a, ProcKrait,
+                                                         FeatureHasRAS,
----------------
I guess there's no easy way to extend it from A9...


Repository:
  rL LLVM

http://reviews.llvm.org/D14660