[PATCH] D14640: [tsan] Inherit TSAN_OPTIONS in allocator_returns_null.cc testcase

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 09:27:45 PST 2015


dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.

LGTM because it can be useful to run tests with custom TSAN_OPTIONS supplied in env.
However, I wonder why do we enable abort_on_error on Mac default (it is not enabled on other OSes), and then disable it as more useful behavior. Won't users also suffer from abort_on_error=1?
I've hit it with Go runtime on Mac. It also lead to a bad behavior and I disabled it for Go on Mac.
Should not we just switch the default to 0?


http://reviews.llvm.org/D14640





More information about the llvm-commits mailing list