[compiler-rt] r253025 - [asan] Fix test to properly handle collisions.

[Daniel Sanders via llvm-commits]

> -----Original Message-----
> From: Yury Gribov [mailto:y.gribov at samsung.com]
> Sent: 13 November 2015 13:22
> To: Daniel Sanders; llvm-commits at lists.llvm.org
> Subject: Re: [compiler-rt] r253025 - [asan] Fix test to properly handle
> collisions.
> 
> On 11/13/2015 04:14 PM, Daniel Sanders wrote:
> > Hi,
> >
> > I believe this commit has caused a failure on the mips buildbot
> http://lab.llvm.org:8011/builders/clang-cmake-mips/builds/10677. Could you
> revert this for now?
> >
> > buildbot won't have sent you a notification because this builder is not
> monitoring compiler-rt properly. I've just committed a fix to the buildbot
> config for this.
> 
> Daniel,
> 
> Thanks, I've also noticed the error and submitted a fix some time ago
> (r253037). It may take some time to propagate.

Great. Build 10680 is testing that revision at the moment so it should turn green again soon.
 
> A general question: how should I proceed with errors on
> non-so-widespread platforms like MIPS or PowerPC? Should I XFAIL and
> contact maintainer? Or try testing on QEMU?
> 
> Best regards,
> Yury Gribov

XFAIL'ing a test reduces the testing performed so it's generally preferable to revert and contact the code owner or bot admin. They should be able to help debug the problem.

Thanks for the quick response.