[PATCH] D14584: [CodeGenPrepare] Create more extloads and fewer ands

[Geoff Berry via llvm-commits]

gberry added a comment.

Quentin,

Thanks for the quick review.  I've added a new revision that addresses your question about removing the old add.  This can't be done in general since it might have a narrower mask or reach the load through a phi, but for the safe cases I now go ahead and remove it.

As for your question about transforming the load to be narrower with a zext, my reservation about doing this here is that I can't check the TLI.shouldReduceLoadWidth() hook here, since it wants to see the load SDNode, so I might end up narrowing some special case loads that the target doesn't want narrowed.  Does this seem reasonable to you?


http://reviews.llvm.org/D14584