[PATCH] D14290: compiler-rt: add make solution to bootstrap for mingw-w64
Saleem Abdulrasool via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 12 12:05:21 PST 2015
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
At the very least, please remove the `-m32` and `-m64`. This is fine for the time being, but I believe that at some point this is going to go away with the rest of the make based build system, so you may have to move to cmake in the near future.
================
Comment at: make/platform/clang_mingw.mk:5
@@ +4,3 @@
+
+CC ?= clang
+AR ?= ar
----------------
This really is better as `cc`.
================
Comment at: make/platform/clang_mingw.mk:22
@@ +21,3 @@
+CFLAGS.builtins-x86_64 := -target x86_64-windows-gnu $(CFLAGS) -m64
+CFLAGS.builtins-i386 := -target i686-windows-gnu $(CFLAGS) -m32
+CFLAGS.builtins-arm := -target armv7-windows-gnu $(CFLAGS)
----------------
Actually, why do you need the ABI specification? The target architecture already does the right thing. That is `-m64` and `-m32` are superfluous.
http://reviews.llvm.org/D14290
More information about the llvm-commits
mailing list