[PATCH] D9009: Value profiling compiler-rt changes

Betul Buyukkurt via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 10:12:42 PST 2015


betulb added a comment.

> davidxl added inline comments.

> 

> ================

>  Comment at: lib/profile/InstrProfiling.c:190

>  @@ +189,3 @@

>  +    }

>  +    I->ValueCounters = (void *)PerSiteCountsHead;

>  +    PerSiteCountsHead = (uint8_t *)VDataPtr;

> 

>  ----------------

> 

> Release memory of ValueCounters ?


This is a function that's running only atexit, I thought of adding it in
but then thought of it as unnecessary too due to this being one of the
very last actions of the run time during the lifetime of the program.

> http://reviews.llvm.org/D9009



http://reviews.llvm.org/D9009





More information about the llvm-commits mailing list