[PATCH] D14606: [ELF2/AArch64] Add support for R_AARCH64_CALL26 and R_AARCH64_JUMP26.
Davide Italiano via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 12 09:27:04 PST 2015
davide added inline comments.
================
Comment at: ELF/Target.cpp:673
@@ +672,3 @@
+ " out of range");
+ write32le(Loc, read32le(Loc) | ((X & 0x0FFFFFFC) >> 2));
+ break;
----------------
You can use or32le, no?
================
Comment at: test/elf2/aarch64-relocs.s:62
@@ +61,3 @@
+.section .SUB,"ax", at progbits
+ nop
+sub:
----------------
Do you need the first nop?
http://reviews.llvm.org/D14606
More information about the llvm-commits
mailing list