[llvm] r252911 - Comment update. NFC.

Rafael Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 09:13:45 PST 2015


Author: rafael
Date: Thu Nov 12 11:13:45 2015
New Revision: 252911

URL: http://llvm.org/viewvc/llvm-project?rev=252911&view=rev
Log:
Comment update. NFC.

Fix the library name.
Don't duplicate the comment in the .cpp file.
Don't repeat the name in the comment.

Modified:
    llvm/trunk/include/llvm/IR/Constant.h
    llvm/trunk/lib/IR/Constants.cpp

Modified: llvm/trunk/include/llvm/IR/Constant.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/Constant.h?rev=252911&r1=252910&r2=252911&view=diff
==============================================================================
--- llvm/trunk/include/llvm/IR/Constant.h (original)
+++ llvm/trunk/include/llvm/IR/Constant.h Thu Nov 12 11:13:45 2015
@@ -92,10 +92,9 @@ public:
     GlobalRelocations = 2
   };
 
-  /// getRelocationInfo - This method classifies the entry according to
-  /// whether or not it may generate a relocation entry.  This must be
-  /// conservative, so if it might codegen to a relocatable entry, it should say
-  /// so.  The return values are:
+  /// This method classifies the entry according to whether or not it may
+  /// generate a relocation entry.  This must be conservative, so if it might
+  /// codegen to a relocatable entry, it should say so.  The return values are:
   ///
   ///  NoRelocation: This constant pool entry is guaranteed to never have a
   ///     relocation applied to it (because it holds a simple constant like
@@ -105,7 +104,7 @@ public:
   ///     linker will never see them.
   ///  GlobalRelocations: This entry may have arbitrary relocations.
   ///
-  /// FIXME: This really should not be in VMCore.
+  /// FIXME: This really should not be in IR.
   PossibleRelocationsTy getRelocationInfo() const;
 
   /// getAggregateElement - For aggregates (struct/array/vector) return the

Modified: llvm/trunk/lib/IR/Constants.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Constants.cpp?rev=252911&r1=252910&r2=252911&view=diff
==============================================================================
--- llvm/trunk/lib/IR/Constants.cpp (original)
+++ llvm/trunk/lib/IR/Constants.cpp Thu Nov 12 11:13:45 2015
@@ -414,22 +414,6 @@ bool Constant::isConstantUsed() const {
   return false;
 }
 
-
-
-/// getRelocationInfo - This method classifies the entry according to
-/// whether or not it may generate a relocation entry.  This must be
-/// conservative, so if it might codegen to a relocatable entry, it should say
-/// so.  The return values are:
-/// 
-///  NoRelocation: This constant pool entry is guaranteed to never have a
-///     relocation applied to it (because it holds a simple constant like
-///     '4').
-///  LocalRelocation: This entry has relocations, but the entries are
-///     guaranteed to be resolvable by the static linker, so the dynamic
-///     linker will never see them.
-///  GlobalRelocations: This entry may have arbitrary relocations.
-///
-/// FIXME: This really should not be in IR.
 Constant::PossibleRelocationsTy Constant::getRelocationInfo() const {
   if (const GlobalValue *GV = dyn_cast<GlobalValue>(this)) {
     if (GV->hasLocalLinkage() || GV->hasHiddenVisibility())




More information about the llvm-commits mailing list