[PATCH] D14526: Don't recompute LCSSA after loop-unrolling when possible.

Michael Zolotukhin via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 11 21:59:31 PST 2015


mzolotukhin marked 4 inline comments as done.

================
Comment at: lib/Transforms/Utils/LoopUnroll.cpp:229
@@ -224,1 +228,3 @@
+      std::all_of(ExitBlocks.begin(), ExitBlocks.end(),
+                  [&](BasicBlock *BB) { return ParentL->contains(BB); });
 
----------------
hfinkel wrote:
> Can't ParentL be nullptr here for a top-level loop?
It can, and that explains failures I see in testing after this change:) I'll fix this by adding `!ParentL ||` before the `std::all_of` call.


http://reviews.llvm.org/D14526





More information about the llvm-commits mailing list