[PATCH] D14593: [WebAssembly] Fix function return type printing

[Dan Gohman via llvm-commits]

sunfish accepted this revision.
sunfish added a comment.
This revision is now accepted and ready to land.

Looks good. This kind of begs the question of whether we should do this for the params too (and maybe further refactor the logic about multiple results after lowering), but I'm ok leaving that for later here.


================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:202
@@ -201,1 +201,3 @@
 
+static void ComputeLegalValueVTs(const Function& F,
+                                 const TargetMachine &TM,
----------------
LLVM style puts the reference by the var, rather than the type.

================
Comment at: lib/Target/WebAssembly/WebAssemblyMachineFunctionInfo.h:42
@@ -41,3 +40,1 @@
-  void addResult(MVT VT) { Results.push_back(VT); }
-  const std::vector<MVT> &getResults() const { return Results; }
 };
----------------
You can delete the Results field itself too.


http://reviews.llvm.org/D14593