[PATCH] D9009: Value profiling compiler-rt changes

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: lib/profile/InstrProfiling.c:175
@@ +174,3 @@
+
+    for (uint32_t i = 0; i < NumVSites; ++i) {
+
----------------
Looks like the structure is very close to ValueProfData structure used in indexed format (except that the later is organized per-value kind, while here it is combined).  It will get all the interfaces for reading etc.

================
Comment at: lib/profile/InstrProfilingBuffer.c:45
@@ -41,3 +44,3 @@
       PROFILE_RANGE_SIZE(Counters) * sizeof(uint64_t) +
-      NamesSize + Padding;
+      NamesSize + Padding2;
 }
----------------
Value Profile Data size is not counted here.

================
Comment at: lib/profile/InstrProfilingBuffer.c:110
@@ -101,2 +109,3 @@
+  UPDATE_memcpy(Zeroes,        Padding2      * sizeof(char));
 #undef UPDATE_memcpy
 
----------------
Value profile data is missing here.


http://reviews.llvm.org/D9009