[PATCH] D14479: Fix bug 25440: GVN assertion after coercing loads

[Daniel Berlin via llvm-commits]

dberlin added a comment.

LGTM

It would be super nice to have testcases for all of these, but i suspect that would be pretty hard to test by hand.

I wonder if it doesn't make sense to have, at the end of GVN:

#ifdef DEBUG

for each instruction

  assert that VN.lookup returns a non-null value

#endif
to make sure we catch all the cases this can happen in.

Because i suspect it happens in loadpre as well, when phitranslate inserts instructions, etc.


http://reviews.llvm.org/D14479