[PATCH] D11172: LegalizeDAG: Fix and improve FCOPYSIGN/FABS legalization

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 11 17:05:32 PST 2015


MatzeB added a comment.

Thanks for the review!


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1666
@@ +1665,3 @@
+  EVT FloatVT = Mag.getValueType();
+  if (TLI.isOperationLegalOrCustom(ISD::FABS, FloatVT) &&
+      TLI.isOperationLegalOrCustom(ISD::FNEG, FloatVT)) {
----------------
hfinkel wrote:
> It looks like this FABS check and expansion can be moved before the call to getSignAsIntValue, and if so, please do that.
The replacement code uses the "SignBit" variable as well so I don't think this can be easily moved.


Repository:
  rL LLVM

http://reviews.llvm.org/D11172





More information about the llvm-commits mailing list