[PATCH] D13308: Value profiling - remaining LLVM changes

Betul Buyukkurt via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 11 15:34:55 PST 2015


betulb updated this revision to Diff 39983.
betulb added a comment.

In this revision:

- RawInstrProfReader is modified to accommodate the changes to the compiler-rt implemented in (http://reviews.llvm.org/D9009) i.e.:
  - Each value site can write up to 255 value data elements to output file.
  - The data type of NumValueSites[] has been changed from uint32_t to uint16_t
  - Max value for the  value kind enum is stored in the header of the raw profile data file.
  - PerSiteValueCounts are embedded into the same array with the actual value data.
  - The __llvm_profile_data struct elements are ordered to make the NumValueSites[] the last member of the struct.
  - Per review comments, ValueCounters member of the  __llvm_profile_data struct is modified during profile file write out to allow for the reader to read profile data file content in a uniform manner. This change however, needs to be revisited as it'd potentially break the buffer API usage, when the value profiling support is added there as well.

The changes in this patch do not include updates to the raw profile files for llvm-profdata testing. Those will be generated when the current set of changes introduced in this CL are agreed upon.


http://reviews.llvm.org/D13308

Files:
  docs/LangRef.rst
  include/llvm/IR/IntrinsicInst.h
  include/llvm/IR/Intrinsics.td
  include/llvm/ProfileData/InstrProf.h
  include/llvm/ProfileData/InstrProfData.inc
  include/llvm/ProfileData/InstrProfReader.h
  lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  lib/ProfileData/InstrProfReader.cpp
  lib/Transforms/Instrumentation/InstrProfiling.cpp
  test/Instrumentation/InstrProfiling/PR23499.ll
  test/Instrumentation/InstrProfiling/linkage.ll
  test/Instrumentation/InstrProfiling/platform.ll
  test/Instrumentation/InstrProfiling/profiling.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13308.39983.patch
Type: text/x-patch
Size: 33217 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151111/1de7a3cb/attachment.bin>


More information about the llvm-commits mailing list