[PATCH] D14558: [llvm-profdata] Add check for text profile formats and improve error reporting

David Li via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 11 15:29:00 PST 2015


davidxl added a comment.

The only limitation here is that when a sample text file is passed to llvm-profdata tool without -sample option, the tool can still not give very useful information -- supporting that requires non trivial refactoring so that 'hasFormat' interfaces are moved to a common place.  Probably not worth the effort.

Looks good to me. Watch out for more comments post-commit.


http://reviews.llvm.org/D14558





More information about the llvm-commits mailing list