[PATCH] D14589: sancov test suite

[Ivan Krasin via llvm-commits]

krasin added inline comments.

================
Comment at: test/CMakeLists.txt:23
@@ -26,1 +22,3 @@
           bugpoint
+          BugpointPasses
+          count
----------------
What was the logic of this reordering? Did you try to put them in the alphabet order? If yes, I think that capital letters should go before regular, i.e. Z < a.

================
Comment at: test/tools/sancov/Inputs/test.cpp:13
@@ +12,3 @@
+__attribute__((noinline))
+std::string bar(std::string str) { printf("bar\n"); return str; }
+
----------------
What is the point of returning the str argument? Why do you return it as the result?


http://reviews.llvm.org/D14589