[PATCH] D14586: [elf2] Implement global dynamic tls.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/InputSection.cpp:129
@@ +128,3 @@
+
+    if (Type == Target->getTlsGlobalDynamicReloc()) {
+      Target->relocateOne(BufLoc, BufEnd, Type, AddrLoc,
----------------
You are not using a return value of getTlsGlobalDynamicReloc except comparing it with Type. Isn't isTlsGlobalDynamicReloc(uint32_t) better than getTlsGlobalDynamicReloc()?

================
Comment at: ELF/OutputSections.cpp:208-210
@@ +207,5 @@
+      auto *PNext = reinterpret_cast<Elf_Rel *>(Buf);
+      (PNext)->setSymbolAndType(Body->getDynamicSymbolTableIndex(),
+                                Target->getTlsOffsetReloc(), Config->Mips64EL);
+      (PNext)->r_offset = Out<ELFT>::Got->getEntryAddr(*Body) + sizeof(uintX_t);
+      continue;
----------------
(PNext) -> PNext


http://reviews.llvm.org/D14586