[PATCH] D14572: sanitizer: add support for trace coverage

[Kostya Serebryany via llvm-commits]

kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.

LGTM with two nits. 
Thanks!


================
Comment at: include/sanitizer/coverage_interface.h:69
@@ +68,3 @@
+  // out of memory.
+  bool __sanitizer_trace_enable(uintptr_t size);
+  // Disable tracing for the current thread and free all associated resources.
----------------
here and below use int instead of bool. 
This API can theoretically be used in C

================
Comment at: lib/Transforms/Instrumentation/SanitizerCoverage.cpp:80
@@ +79,3 @@
+    ClTracing("sanitizer-coverage-trace",
+                          cl::desc("Tacing: insert callbacks at every basic"
+                                   " function/block/edge"),
----------------
typo: Tacing


http://reviews.llvm.org/D14572